Arm backend: Add support for aten.slice_copy with non-unit step #16872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decompose strided slice_copy into unit-step slice_copy plus optional right padding and view_copy reshapes - Update SliceCopySupported check for the supported pattern - Add non-unit-step slice tests Change-Id: Ida60ee2f42c283d50c9e3185dca1f9ea2238cf83 Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
Change-Id: I8479a4daed1e8be4bda4591e04dfbcadc297ab4f Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
added
partner: arm
meta-cla
bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16872
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 62a9751 with merge base 7770407 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Change-Id: I06319f5378a3fed60f5f20499671389dbd0e68e8 Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
zingo
approved these changes
Jan 27, 2026
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
OK to merge is Arm Backend tests pass
Collaborator
Author
|
cortex-m-backend failure unrelated |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 27, 2026
…ep (pytorch#16872)" This reverts commit b5fe947.
Member
|
@YufengShi-dudu FYI It looks like this PR broke some of the nightly U55/U85 tests. I'm likely going to revert to fix CI, sorry. I'm happy to help get it re-landed. More details are in #16914. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ida60ee2f42c283d50c9e3185dca1f9ea2238cf83
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai